WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
305520
Digital Credentials: Fix safer C++ checker warnings in WKDigitalCredentialsPicker.mm
https://bugs.webkit.org/show_bug.cgi?id=305520
Summary
Digital Credentials: Fix safer C++ checker warnings in WKDigitalCredentialsPi...
Marcos Caceres
Reported
2026-01-14 16:32:01 PST
WebKit's safer C++ checker flagged several memory safety issues in WKDigitalCredentialsPicker.mm related to improper smart pointer usage when calling non-trivial member functions. The safer C++ checker identified four violations of WebKit's safer C++ guidelines: * fetchRawRequestsWithCompletionHandler:line 242 - "Uncounted call argument for a raw pointer/reference parameter" * handleNSError:line 413 - "Uncounted call argument for a raw pointer/reference parameter" * presentationAnchor:line 236 - "Unretained call argument for a raw pointer/reference parameter" * mapRequestAuthentications:line 192 - "Unretained raw pointer or reference not provably backed by a RetainPtr"
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2026-01-14 16:40:29 PST
<
rdar://problem/168182333
>
Marcos Caceres
Comment 2
2026-01-14 16:42:56 PST
Pull request:
https://github.com/WebKit/WebKit/pull/56599
EWS
Comment 3
2026-01-15 07:56:53 PST
Committed
305642@main
(b8dfd19251f6): <
https://commits.webkit.org/305642@main
> Reviewed commits have been landed. Closing PR #56599 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug