RESOLVED FIXED305435
[libpas] Hold lock during retag-on-scavenge tag-setting for bitfit heaps
https://bugs.webkit.org/show_bug.cgi?id=305435
Summary [libpas] Hold lock during retag-on-scavenge tag-setting for bitfit heaps
Marcus Plutowski
Reported 2026-01-13 16:44:34 PST
rdar://165772439 Previously, we were doing the tag-writes outside of the mutex; this is unsafe since it also takes place strictly after the slot is returned to use, so it's possible for the memory to be re-allocated while we're tagging it.
Attachments
Marcus Plutowski
Comment 1 2026-01-13 16:44:59 PST
The feature is not currently enabled, so when the above goes in we can turn it on at the same time.
Marcus Plutowski
Comment 2 2026-01-14 15:32:04 PST
EWS
Comment 3 2026-01-21 15:37:10 PST
Committed 305977@main (9705a6950cd2): <https://commits.webkit.org/305977@main> Reviewed commits have been landed. Closing PR #56594 and removing active labels.
WebKit Commit Bot
Comment 4 2026-01-27 19:00:38 PST
Re-opened since this is blocked by bug 306391
Marcus Plutowski
Comment 5 2026-02-03 13:05:58 PST
EWS
Comment 6 2026-02-04 08:14:21 PST
Committed 306782@main (68505be6c8c4): <https://commits.webkit.org/306782@main> Reviewed commits have been landed. Closing PR #57804 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.