RESOLVED FIXED305233
JSC::getCallDataInline has fragile include dependency on unified sources 
https://bugs.webkit.org/show_bug.cgi?id=305233
Summary JSC::getCallDataInline has fragile include dependency on unified sources
Vassili Bykov
Reported 2026-01-09 16:05:03 PST
The inline function JSC::getCallDataInline() in JSObjectInlines.h calls JSFunction::getCallDataInline() from JSFunctionInlines.h. Because of that, it requires JSFunctionInlines.h to be included at that point. However, there is no explicit include to guarantee this. The code only builds because unified sources happen to bundle translation units in a favorable order. This is fragile, and the build broke for me with in an old toolchain on Sonoma.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2026-01-09 16:05:11 PST
<rdar://problem/167876001>
Vassili Bykov
Comment 2 2026-01-09 17:38:03 PST
Pull request: https://github.com/WebKit/WebKit/pull/56374
EWS
Comment 3 2026-01-13 15:58:26 PST
Committed 305548@main (cda948675446): <https://commits.webkit.org/305548@main> Reviewed commits have been landed. Closing PR #56374 and removing active labels.
Alberto Garcia
Comment 4 2026-01-14 05:28:44 PST
*** Bug 305387 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.