Bug 30514 - REGRESSION (r49619): Focus ring that appears after clicking a link is so noticeable that it looks broken
Summary: REGRESSION (r49619): Focus ring that appears after clicking a link is so noti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, PlatformOnly, Regression
Depends on:
Blocks:
 
Reported: 2009-10-19 08:55 PDT by Adam Roben (:aroben)
Modified: 2009-10-30 09:38 PDT (History)
1 user (show)

See Also:


Attachments
screenshot after clicking on a link on webkit.org (7.54 KB, image/png)
2009-10-19 08:59 PDT, Adam Roben (:aroben)
no flags Details
Screenshot after clicking on a photo on facebook.com (39.92 KB, image/png)
2009-10-19 09:02 PDT, Adam Roben (:aroben)
no flags Details
Screenshot after clicking on a link on webkit.org in Internet Explorer (4.67 KB, image/png)
2009-10-19 09:04 PDT, Adam Roben (:aroben)
no flags Details
screenshot after clicking on a photo on facebook.com in Internet Explorer (39.71 KB, image/png)
2009-10-19 09:05 PDT, Adam Roben (:aroben)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-10-19 08:55:00 PDT
r49619 <http://trac.webkit.org/changeset/49619> made links and buttons become focused when clicked on Windows. This new behavior matches Firefox and IE, which is good. (See bug 26856 if you want more details.) But Safari's focus ring is so much more noticeable than Firefox and IE's focus rings that this behavior looks like a bug.

To reproduce:
1. Go to http://webkit.org/
2. Click on any link on the page, including the "Download Nightly builds" button on the right

A very noticeable blue focus ring appears. In Firefox and IE, a much more subtle focus ring appears.
Comment 1 Adam Roben (:aroben) 2009-10-19 08:55:50 PDT
<rdar://problem/7315104>
Comment 2 Adam Roben (:aroben) 2009-10-19 08:57:59 PDT
(In reply to comment #0)
> 2. Click on any link on the page, including the "Download Nightly builds"
> button on the right

I was mistaken. The "Download Nightly builds" button does not exhibit this issue.
Comment 3 Adam Roben (:aroben) 2009-10-19 08:59:18 PDT
Created attachment 41419 [details]
screenshot after clicking on a link on webkit.org
Comment 4 Adam Roben (:aroben) 2009-10-19 09:02:14 PDT
Created attachment 41420 [details]
Screenshot after clicking on a photo on facebook.com

Here's an especially broken-looking case.
Comment 5 Adam Roben (:aroben) 2009-10-19 09:04:41 PDT
Created attachment 41421 [details]
Screenshot after clicking on a link on webkit.org in Internet Explorer
Comment 6 Adam Roben (:aroben) 2009-10-19 09:05:03 PDT
Created attachment 41422 [details]
screenshot after clicking on a photo on facebook.com in Internet Explorer
Comment 7 Adam Roben (:aroben) 2009-10-30 09:38:38 PDT
Looks like we're no longer showing focus rings on click as of r50315 <http://trac.webkit.org/changeset/50315>. See bug 30523 comment 20 and subsequent comments.