Bug 30513 - All HTML5 media element events should be regular events
Summary: All HTML5 media element events should be regular events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-19 08:38 PDT by Eric Carlson
Modified: 2009-11-30 13:45 PST (History)
0 users

See Also:


Attachments
Proposed patch (13.19 KB, patch)
2009-11-30 09:51 PST, Eric Carlson
simon.fraser: review-
Details | Formatted Diff | Diff
Updated patch to call renderer->updateFromElement when posting a 'progress' event. (13.50 KB, patch)
2009-11-30 10:17 PST, Eric Carlson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2009-10-19 08:38:07 PDT
r4133 changed all progress events to regular events the "loaded" field doesn't make sense for a media engine that doesn't keep data buffered, and because we don't have a concept of "loaded" any more.

http://html5.org/tools/web-apps-tracker?from=4132&to=4133
Comment 1 Eric Carlson 2009-11-30 09:51:27 PST
Created attachment 44026 [details]
Proposed patch
Comment 2 Simon Fraser (smfr) 2009-11-30 09:58:11 PST
Comment on attachment 44026 [details]
Proposed patch

scheduleProgressEvent() used to call updateFromElement(), which I think updated the controller for a progressively downloaded file. I'm not sure what will do that now.
Comment 3 Eric Carlson 2009-11-30 10:17:25 PST
Created attachment 44027 [details]
Updated patch to call renderer->updateFromElement when posting a 'progress' event.
Comment 4 Eric Carlson 2009-11-30 13:45:13 PST
http://trac.webkit.org/changeset/51511