WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
305051
[GTK][WPE] remove dead code from WebPageProxy::activityStateDidChange
https://bugs.webkit.org/show_bug.cgi?id=305051
Summary
[GTK][WPE] remove dead code from WebPageProxy::activityStateDidChange
Przemyslaw Gorszkowski
Reported
2026-01-07 06:07:18 PST
There is #elif, which will never be called: #if PLATFORM(COCOA) || PLATFORM(GTK) || PLATFORM(WPE) bool isNewlyInWindow = !isInWindow() && (mayHaveChanged & ActivityState::IsInWindow) && pageClient->isViewInWindow(); if (dispatchMode == ActivityStateChangeDispatchMode::Immediate || isNewlyInWindow) { dispatchActivityStateChange(); return; } scheduleActivityStateUpdate(); #elif PLATFORM(GTK) || PLATFORM(WPE) UNUSED_PARAM(dispatchMode); scheduleActivityStateUpdate(); #else UNUSED_PARAM(dispatchMode); dispatchActivityStateChange(); #endif
Attachments
Add attachment
proposed patch, testcase, etc.
Przemyslaw Gorszkowski
Comment 1
2026-01-07 06:14:13 PST
Pull request:
https://github.com/WebKit/WebKit/pull/56198
EWS
Comment 2
2026-01-08 02:31:55 PST
Committed
305264@main
(521c611f97c4): <
https://commits.webkit.org/305264@main
> Reviewed commits have been landed. Closing PR #56198 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2026-01-08 02:32:12 PST
<
rdar://problem/167754312
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug