Bug 30496 - Web Inspector: make console tests more granular.
Summary: Web Inspector: make console tests more granular.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-18 16:33 PDT by Pavel Feldman
Modified: 2009-10-19 09:31 PDT (History)
1 user (show)

See Also:

Attachments
patch (10.43 KB, patch)
2009-10-18 16:34 PDT, Pavel Feldman 		timothy: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-10-18 16:33:25 PDT 
Split console tests into dir, dirxml, format and log level tests.
Comment 1 Pavel Feldman 2009-10-18 16:34:32 PDT 
Created attachment 41388 [details]
patch
Comment 2 Timothy Hatcher 2009-10-18 16:37:44 PDT 
Comment on attachment 41388 [details]
patch

Is function callback(result) somethign we can share between tests?
Comment 3 Pavel Feldman 2009-10-18 17:13:34 PDT 
(In reply to comment #2)
> (From update of attachment 41388 [details])
> Is function callback(result) somethign we can share between tests?

We should be able to do that by means of console-tests.js or something. But given that these tests are supposed to test different things, they could diverge. Fortammer's one is already different...
Comment 4 Timothy Hatcher 2009-10-18 18:38:33 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 41388 [details] [details])
> > Is function callback(result) somethign we can share between tests?
> 
> We should be able to do that by means of console-tests.js or something. But
> given that these tests are supposed to test different things, they could
> diverge. Fortammer's one is already different...

OK
Comment 5 Yong Li 2009-10-19 08:47:05 PDT 
Comment on attachment 41388 [details]
patch

Let commit bot land it
Comment 6 WebKit Commit Bot 2009-10-19 08:48:15 PDT 
Comment on attachment 41388 [details]
patch

Rejecting patch 41388 from commit-queue.

Patch https://bugs.webkit.org/attachment.cgi?id=41388 from bug 30496 failed to download and apply.
Comment 7 Pavel Feldman 2009-10-19 09:31:28 PDT 
Landed as r49760