Bug 30495 - Move feGaussianBlur from WebCore/svg to WebCore/platform
Summary: Move feGaussianBlur from WebCore/svg to WebCore/platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 525.x (Safari 3.1)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-18 13:29 PDT by Dirk Schulze
Modified: 2009-10-19 11:13 PDT (History)
0 users

See Also:


Attachments
Move feGaussianBlur out of SVG (28.61 KB, patch)
2009-10-18 13:33 PDT, Dirk Schulze
darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2009-10-18 13:29:09 PDT
Qt and Cairo don't have shadow support. An idea is to use the filter feGaussianBlur from SVG to render shadows. Therefore it is neccessary to move svg/graphics/filters/SVGFEGaussianBlur to platform/graphics/filters/FEGaussianBlur.
Comment 1 Dirk Schulze 2009-10-18 13:33:30 PDT
Created attachment 41385 [details]
Move feGaussianBlur out of SVG

patch
Comment 2 Darin Adler 2009-10-18 16:20:08 PDT
Comment on attachment 41385 [details]
Move feGaussianBlur out of SVG

Ideally, this patch should be done with "svn move" rather than just copying the file in the new place, to keep the revision history. The tools such as svn-create-patch and svn-apply know how to handle such patches.

Also, I see little point in listing all the functions in the change log for a newly added file.

r=me as is, but please consider doing the patch the better way
Comment 3 Yong Li 2009-10-19 08:51:11 PDT
Comment on attachment 41385 [details]
Move feGaussianBlur out of SVG

Let commit bot land it
Comment 4 WebKit Commit Bot 2009-10-19 09:26:45 PDT
Comment on attachment 41385 [details]
Move feGaussianBlur out of SVG

Rejecting patch 41385 from commit-queue.

Patch https://bugs.webkit.org/attachment.cgi?id=41385 from bug 30495 failed to download and apply.
Comment 5 Dirk Schulze 2009-10-19 11:13:00 PDT
Sorry, forgot to close this bug :-(
landed in r49778