Bug 30486 – Web Inspector: Title of dir(["test", "test2"]) should be Array

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Timothy Hatcher]

We use the toString value when printing the title of the expandable tree for arrays. But we don't do this for other objects (from what I can tell.)

dir(["test", "test1,test2"])

results in:

[test,test1,test2]

This shows the poor toString support for Arrays.

We should just say Array for the title.

[Pavel Feldman]

Created attachment 41376 [details]
patch

[Pavel Feldman]

Created attachment 41377 [details]
same with "NodeList" as node list title.

[Timothy Hatcher]

Comment on attachment 41377 [details]
same with "NodeList" as node list title.

Yay. Tests!

[Joseph Pecoraro]

In context:

>     case "object"
>     case "node":
>         return type2;
>     case "array":
>         return type2;

How about adding "array" to the fall-through cases above?

[Timothy Hatcher]

(In reply to comment #4)
> In context:
> 
> >     case "object"
> >     case "node":
> >         return type2;
> >     case "array":
> >         return type2;
> 
> How about adding "array" to the fall-through cases above?

Good point, that would be better.

[Pavel Feldman]

> How about adding "array" to the fall-through cases above?

Done.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/inspector/console-tests-expected.txt
	M	LayoutTests/inspector/console-tests.html
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/InjectedScript.js
Committed r49758