Bug 30474 - Use _stricmp and _strnicmp instead of deprecated stricmp and strnicmp.
Summary: Use _stricmp and _strnicmp instead of deprecated stricmp and strnicmp.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-10-16 20:50 PDT by Kwang Yul Seo
Modified: 2009-10-18 23:43 PDT (History)
5 users (show)

See Also:

Use ISO C++ conformant _stricmp and _strnicmp (1.29 KB, patch)
2009-10-16 20:53 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Update ChangeLog (1.27 KB, patch)
2009-10-17 00:43 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2009-10-16 20:50:34 PDT
POSIX function such as stricmp and strnicmp are deprecated beginning in Visual C++ 2005. Use ISO C++ conformant _stricmp and _strnicmp instead in StringExtras.h.
Comment 1 Kwang Yul Seo 2009-10-16 20:53:50 PDT
Created attachment 41350 [details]
Use ISO C++ conformant _stricmp and _strnicmp
Comment 2 Eric Seidel (no email) 2009-10-16 23:36:32 PDT
darin, arboen or sfalken are likely better reviewers for this than I.
Comment 3 Mark Rowe (bdash) 2009-10-17 00:07:27 PDT
The bug title, ChangeLog, and Visual Studio warning are incredibly misleading.  strnicmp is not part of POSIX and _strnicmp is certainly not part part of the ISO C++ standard.  They’re both Microsoft extensions.  The change itself is probably fine but IMO the ChangeLog should be corrected.
Comment 4 Kwang Yul Seo 2009-10-17 00:41:46 PDT
Change the title.
Comment 5 Kwang Yul Seo 2009-10-17 00:43:37 PDT
Created attachment 41354 [details]
Update ChangeLog

Update the ChangeLog because stricmp and strnicmp are not POSIX functions but Microsfot extensions.
Comment 6 WebKit Commit Bot 2009-10-18 23:43:51 PDT
Comment on attachment 41354 [details]
Update ChangeLog

Clearing flags on attachment: 41354

Committed r49765: <http://trac.webkit.org/changeset/49765>
Comment 7 WebKit Commit Bot 2009-10-18 23:43:55 PDT
All reviewed patches have been landed.  Closing bug.