WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
30472
EventHandler::eventLoopHandleMouseDragged needs ENABLE(DRAG_SUPPORT) guards
https://bugs.webkit.org/show_bug.cgi?id=30472
Summary
EventHandler::eventLoopHandleMouseDragged needs ENABLE(DRAG_SUPPORT) guards
Kwang Yul Seo
Reported
2009-10-16 20:13:28 PDT
There are ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged in EventHandler.h, but missing in EventHandler.cpp. MSVC fails to compile when DRAG_SUPPORT is not enabled.
Attachments
ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged
(1.15 KB, patch)
2009-10-16 20:17 PDT
,
Kwang Yul Seo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1
2009-10-16 20:17:29 PDT
Created
attachment 41346
[details]
ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged
Eric Seidel (no email)
Comment 2
2009-10-16 23:34:48 PDT
Comment on
attachment 41346
[details]
ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged Makes no sense that that is marked "inline". But this looks OK. The latter #endif really should have a comment explaingin which #if its ending.
Eric Seidel (no email)
Comment 3
2009-10-16 23:35:39 PDT
CCing drag and drop folks so they see this go by.
WebKit Commit Bot
Comment 4
2009-10-17 08:54:32 PDT
Comment on
attachment 41346
[details]
ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged Clearing flags on attachment: 41346 Committed
r49742
: <
http://trac.webkit.org/changeset/49742
>
WebKit Commit Bot
Comment 5
2009-10-17 08:54:41 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug