Bug 30472 - EventHandler::eventLoopHandleMouseDragged needs ENABLE(DRAG_SUPPORT) guards
Summary: EventHandler::eventLoopHandleMouseDragged needs ENABLE(DRAG_SUPPORT) guards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-16 20:13 PDT by Kwang Yul Seo
Modified: 2009-10-17 08:54 PDT (History)
4 users (show)

See Also:

Attachments
ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged (1.15 KB, patch)
2009-10-16 20:17 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2009-10-16 20:13:28 PDT 
There are ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged in EventHandler.h, but missing in EventHandler.cpp. 

MSVC fails to compile when DRAG_SUPPORT is not enabled.
Comment 1 Kwang Yul Seo 2009-10-16 20:17:29 PDT 
Created attachment 41346 [details]
ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged
Comment 2 Eric Seidel (no email) 2009-10-16 23:34:48 PDT 
Comment on attachment 41346 [details]
ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged

Makes no sense that that is marked "inline".  But this looks OK.

The latter #endif really should have a comment explaingin which #if its ending.
Comment 3 Eric Seidel (no email) 2009-10-16 23:35:39 PDT 
CCing drag and drop folks so they see this go by.
Comment 4 WebKit Commit Bot 2009-10-17 08:54:32 PDT 
Comment on attachment 41346 [details]
ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged

Clearing flags on attachment: 41346

Committed r49742: <http://trac.webkit.org/changeset/49742>
Comment 5 WebKit Commit Bot 2009-10-17 08:54:41 PDT 
All reviewed patches have been landed.  Closing bug.