Bug 30468 - structure typeinfo flags should be inherited.
Summary: structure typeinfo flags should be inherited.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-16 16:18 PDT by Oliver Hunt
Modified: 2010-01-10 15:08 PST (History)
0 users

See Also:


Attachments
JavaScriptCore portion of patch (26.69 KB, patch)
2009-10-16 16:32 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-10-16 16:18:42 PDT
We have all sorts of problems due to subclasses not setting the right typeinfo flags due to  unawareness of flags set by their parent class.

Following the recent typeinfo flag refactoring it is now possible to do this relatively easily, and so we should.
Comment 1 Oliver Hunt 2009-10-16 16:32:48 PDT
Created attachment 41340 [details]
JavaScriptCore portion of patch
Comment 2 Gavin Barraclough 2009-10-16 16:56:53 PDT
Comment on attachment 41340 [details]
JavaScriptCore portion of patch

Move the JSByteArray createStructure to the header or you're officially lame!
Meh, r+ either way. :-(
Comment 3 Oliver Hunt 2009-10-16 18:07:52 PDT
Comment on attachment 41340 [details]
JavaScriptCore portion of patch

Committed r49721
Comment 4 Mark Rowe (bdash) 2009-10-19 00:17:32 PDT
Comment on attachment 41340 [details]
JavaScriptCore portion of patch

Clearing review flag since this was landed.