object is created and never deleted. m_item->setPage(new WebPage());
Created attachment 41334 [details] (committed in r49730) patch 0.1 - make it not leak
Yes, when a page is created by the app, the app has the ownership and should destroy it. so LGTM, though I do not like the (m_page = new WebPage) part very much, but that is just a nit.
Comment on attachment 41334 [details] (committed in r49730) patch 0.1 - make it not leak You could also make it a child of the mainwindow or the view, to get Qt automatically delete it. But this is okay, too :-)
r49730
Comment on attachment 41334 [details] (committed in r49730) patch 0.1 - make it not leak thx simon and kenneth