Bug 304644 – [Debug][GTK] inspector/unit-tests/editing-support.html crashes

• Status: REOPENED
• Component: WebKitGTK

[Claudio Saavedra]

In the bot it looks like a timeout, but it's actually an assertion crash. For this reason it also crashes (timeouts) in EWS with assertions enabled.

#0  WTFCrash () at ../../../Source/WTF/wtf/Assertions.cpp:380
#1  0x00007ff544800960 in WTFCrashWithInfo () at WTF/Headers/wtf/Assertions.h:985
#2  0x00007ff54c843fa1 in WebCore::VisiblePosition::previous (this=0x7ffc8721f620, rule=WebCore::CanCrossEditingBoundary, reachedBoundary=0x0) at ../../../Source/WebCore/editing/VisiblePosition.cpp:111
#3  0x00007ff54c8406a3 in WebCore::TypingCommand::markMisspellingsAfterTyping (this=0x7ff51e611140, commandType=WebCore::TypingCommand::Type::InsertText) at ../../../Source/WebCore/editing/TypingCommand.cpp:467
#4  0x00007ff54c840b74 in WebCore::TypingCommand::typingAddedToOpenCommand (this=0x7ff51e611140, commandTypeForAddedTyping=WebCore::TypingCommand::Type::InsertText)
    at ../../../Source/WebCore/editing/TypingCommand.cpp:527
#5  0x00007ff54c840f4e in WebCore::TypingCommand::insertTextRunWithoutNewlines (this=0x7ff51e611140, text=..., selectInsertedText=false) at ../../../Source/WebCore/editing/TypingCommand.cpp:563
#6  0x00007ff54c83e8ec in WebCore::TypingCommandLineOperation::operator() (this=0x7ffc8721f840, lineOffset=0, lineLength=6, isLastLine=true) at ../../../Source/WebCore/editing/TypingCommand.cpp:73
#7  0x00007ff54c85d30f in WebCore::forEachLineInString<WebCore::TypingCommandLineOperation> (string=..., operation=...) at ../../../Source/WebCore/editing/TextInsertionBaseCommand.h:60
#8  0x00007ff54c840c2f in WebCore::TypingCommand::insertText (this=0x7ff51e611140, text=..., selectInsertedText=false) at ../../../Source/WebCore/editing/TypingCommand.cpp:540
#9  0x00007ff54c840d30 in WebCore::TypingCommand::insertTextAndNotifyAccessibility (this=0x7ff51e611140, text=..., selectInsertedText=false) at ../../../Source/WebCore/editing/TypingCommand.cpp:548
#10 0x00007ff54c8402f1 in WebCore::TypingCommand::doApply (this=0x7ff51e611140) at ../../../Source/WebCore/editing/TypingCommand.cpp:395
#11 0x00007ff54c720cc6 in WebCore::CompositeEditCommand::apply (this=0x7ff51e611140) at ../../../Source/WebCore/editing/CompositeEditCommand.cpp:418
#12 0x00007ff54c803cb9 in WebCore::TextInsertionBaseCommand::applyTextInsertionCommand (frame=0x7ff51e0614a0, command=..., selectionForInsertion=..., endingSelection=...)
    at ../../../Source/WebCore/editing/TextInsertionBaseCommand.cpp:50
#13 0x00007ff54c83f947 in WebCore::TypingCommand::insertText
    (document=..., text=..., triggeringEvent=0x0, selectionForInsertion=..., options=..., compositionType=WebCore::TypingCommand::TextCompositionType::None)
    at ../../../Source/WebCore/editing/TypingCommand.cpp:274
#14 0x00007ff54c83f53a in WebCore::TypingCommand::insertText (document=..., text=..., triggeringEvent=0x0, options=..., composition=WebCore::TypingCommand::TextCompositionType::None)
    at ../../../Source/WebCore/editing/TypingCommand.cpp:234
#15 0x00007ff54c785565 in WebCore::executeInsertText (frame=..., event=0x0, value=...) at ../../../Source/WebCore/editing/EditorCommand.cpp:539
#16 0x00007ff54c78d94f in WebCore::Editor::Command::execute (this=0x7ffc8721fbf0, parameter=..., triggeringEvent=0x0) at ../../../Source/WebCore/editing/EditorCommand.cpp:1925
#17 0x00007ff54c31e869 in WebCore::Document::execCommand (this=0x7ff51c0c6000, commandName=..., userInterface=false, value=...) at ../../../Source/WebCore/dom/Document.cpp:8010
#18 0x00007ff5483cf6b0 in WebCore::jsDocumentPrototypeFunction_execCommandBody (lexicalGlobalObject=0x7ff51c122088, callFrame=0x7ffc8721fec0, castedThis=0x7ff51e017748)
    at WebCore/DerivedSources/JSDocument.cpp:7003
#19 0x00007ff548403563 in WebCore::IDLOperation<WebCore::JSDocument>::call<WebCore::jsDocumentPrototypeFunction_execCommandBody>
    (lexicalGlobalObject=..., callFrame=..., operationName=0x7ff53a1c628c "execCommand") at WebCore/PrivateHeaders/WebCore/JSDOMOperation.h:63
#20 0x00007ff5483cf7b9 in WebCore::jsDocumentPrototypeFunction_execCommand (lexicalGlobalObject=0x7ff51c122088, callFrame=0x7ffc8721fec0) at WebCore/DerivedSources/JSDocument.cpp:7008
#21 0x00007ff4db40c038 in ??? ()
#22 0x00007ffc8721ffa0 in ??? ()
#23 0x00007ff53212af1b in llint_op_call_ignore_result () at /host/home/claudio/git/webkit/WebKit/WebKitBuild/GTK/Debug/lib/libjavascriptcoregtk-6.0.so.1
#24 0x0000000000000000 in ??? ()

[Claudio Saavedra]

Pull request: https://github.com/WebKit/WebKit/pull/55830

[EWS]

Test gardening commit 304902@main (8ba7854ee96a): <https://commits.webkit.org/304902@main>

Reviewed commits have been landed. Closing PR #55830 and removing active labels.

[Alicia Boya García]

The crash stopped happening somewhere in 304906@main-304907@main. Removing expectations...

[Fujii Hironori]

inspector/unit-tests/editing-support.html still has a problem.
Alicia submitted a patch removing the marker, GTK-WK2-Tests-EWS reported it timed out with an assertion failure. This is another assertion failure to comment#0.
https://ews-build.webkit.org/#/builders/1/builds/119521

https://ews-build.s3-us-west-2.amazonaws.com/GTK-WK2-Tests-EWS/8bebfbad-119521/inspector/unit-tests/editing-support-stderr.txt

VM 0x7f79ea400000 on pid 1155296 received NeedDebuggerBreak trap
ASSERTION FAILED: inSameLine(upstreamCopy, prev)
../../../Source/WebCore/editing/VisiblePosition.cpp(111) : WebCore::VisiblePosition WebCore::VisiblePosition::previous(WebCore::EditingBoundaryCrossingRule, bool*) const
1   0x7f7877d1ffe4 WebCore::VisiblePosition::previous(WebCore::EditingBoundaryCrossingRule, bool*) const
2   0x7f7877d2e073 WebCore::TypingCommand::markMisspellingsAfterTyping(WebCore::TypingCommand::Type)
3   0x7f7877d2e326 WebCore::TypingCommand::typingAddedToOpenCommand(WebCore::TypingCommand::Type)
4   0x7f7877d31f63 WebCore::TypingCommandLineOperation::operator()(unsigned long, unsigned long, bool) const
5   0x7f7877d3258d WebCore::TypingCommand::insertText(WTF::String const&, bool)
6   0x7f7877d3289a WebCore::TypingCommand::insertTextAndNotifyAccessibility(WTF::String const&, bool)
7   0x7f7877bd2776 WebCore::CompositeEditCommand::apply()
8   0x7f7877d3a486 WebCore::TypingCommand::insertText(WTF::Ref<WebCore::Document, WTF::RawPtrTraits<WebCore::Document>, WTF::DefaultRefDerefTraits<WebCore::Document> >&&, WTF::String const&, WebCore::Event*, WebCore::VisibleSelection const&, WTF::OptionSet<WebCore::TypingCommand::Option, (WTF::ConcurrencyTag)0>, WebCore::TypingCommand::TextCompositionType)
9   0x7f7877c26615 WebCore::executeInsertText(WebCore::LocalFrame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&)
10  0x7f7877c33c77 WebCore::Editor::Command::execute(WTF::String const&, WebCore::Event*) const
11  0x7f78779da2dd WebCore::Document::execCommand(WTF::String const&, bool, mpark::variant<WTF::String, WTF::Ref<WebCore::TrustedHTML, WTF::RawPtrTraits<WebCore::TrustedHTML>, WTF::DefaultRefDerefTraits<WebCore::TrustedHTML> > > const&)
12  0x7f78759eca04 WebCore::jsDocumentPrototypeFunction_execCommand(JSC::JSGlobalObject*, JSC::CallFrame*)
13  0x7f7816e0c038 ???

https://ews-build.s3-us-west-2.amazonaws.com/GTK-WK2-Tests-EWS/8bebfbad-119521/inspector/unit-tests/editing-support-actual.txt

FAIL: Timed out waiting for notifyDone to be called

Testing that WI.incrementElementValue works for numeric values.


== Running test suite: WI.incrementElementValue
-- Running test case: incrementElementValue.numeric