Bug 30464 - Remove HTML5 media element 'load' event
: Remove HTML5 media element 'load' event
Status: RESOLVED FIXED
: WebKit
Media Elements
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-10-16 15:02 PST by
Modified: 2010-07-19 22:30 PST (History)


Attachments
Patch 1: change layout tests (59.49 KB, patch)
2009-10-19 09:21 PST, Eric Carlson
no flags Review Patch | Details | Formatted Diff | Diff
proposed patch (20.09 KB, patch)
2010-07-18 13:42 PST, Eric Carlson
no flags Review Patch | Details | Formatted Diff | Diff
Better patch, fix a bogus 'FAIL' log. (21.75 KB, patch)
2010-07-18 13:55 PST, Eric Carlson
sam: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-10-16 15:02:59 PST
r4132 removed the 'load' event - http://html5.org/tools/web-apps-tracker?from=4131&to=4132
------- Comment #1 From 2009-10-19 09:21:36 PST -------
Created an attachment (id=41424) [details]
Patch 1: change layout tests
------- Comment #2 From 2009-10-19 14:00:50 PST -------
(From update of attachment 41424 [details])
Looks sane enough to me.
------- Comment #3 From 2009-10-19 14:51:02 PST -------
Oh boy this is exciting!!!

Change looks good.. canplaythrough is analogous to load with the exception that seeking will cause canplaythrough to fire again

However I don't see any layout tests that would get confused by this
------- Comment #4 From 2009-10-26 08:29:15 PST -------
First patch submitted, http://trac.webkit.org/changeset/50063
------- Comment #5 From 2010-07-18 13:42:58 PST -------
Created an attachment (id=61910) [details]
proposed patch
------- Comment #6 From 2010-07-18 13:55:16 PST -------
Created an attachment (id=61911) [details]
Better patch, fix a bogus 'FAIL' log.
------- Comment #7 From 2010-07-19 13:20:06 PST -------
http://trac.webkit.org/changeset/63684
------- Comment #8 From 2010-07-19 13:47:45 PST -------
http://trac.webkit.org/changeset/63684 might have broken GTK Linux 32-bit Release and Qt Linux Release
------- Comment #9 From 2010-07-19 22:30:23 PST -------
(In reply to comment #8)
> http://trac.webkit.org/changeset/63684 might have broken GTK Linux 32-bit Release and Qt Linux Release

And all Mac bot. :(

fast/dom/Window/window-properties-expected.txt files updated in http://trac.webkit.org/changeset/63720