Bug 30464 - Remove HTML5 media element 'load' event
: Remove HTML5 media element 'load' event
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Media Elements
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Eric Carlson
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-16 15:02 PDT by Eric Carlson
Modified: 2010-07-19 22:30 PDT (History)
5 users (show)

See Also:


Attachments
Patch 1: change layout tests (59.49 KB, patch)
2009-10-19 09:21 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
proposed patch (20.09 KB, patch)
2010-07-18 13:42 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Better patch, fix a bogus 'FAIL' log. (21.75 KB, patch)
2010-07-18 13:55 PDT, Eric Carlson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2009-10-16 15:02:59 PDT
r4132 removed the 'load' event - http://html5.org/tools/web-apps-tracker?from=4131&to=4132
Comment 1 Eric Carlson 2009-10-19 09:21:36 PDT
Created attachment 41424 [details]
Patch 1: change layout tests
Comment 2 Eric Seidel 2009-10-19 14:00:50 PDT
Comment on attachment 41424 [details]
Patch 1: change layout tests

Looks sane enough to me.
Comment 3 Andrew Scherkus 2009-10-19 14:51:02 PDT
Oh boy this is exciting!!!

Change looks good.. canplaythrough is analogous to load with the exception that seeking will cause canplaythrough to fire again

However I don't see any layout tests that would get confused by this
Comment 4 Eric Carlson 2009-10-26 08:29:15 PDT
First patch submitted, http://trac.webkit.org/changeset/50063
Comment 5 Eric Carlson 2010-07-18 13:42:58 PDT
Created attachment 61910 [details]
proposed patch
Comment 6 Eric Carlson 2010-07-18 13:55:16 PDT
Created attachment 61911 [details]
Better patch, fix a bogus 'FAIL' log.
Comment 7 Eric Carlson 2010-07-19 13:20:06 PDT
http://trac.webkit.org/changeset/63684
Comment 8 WebKit Review Bot 2010-07-19 13:47:45 PDT
http://trac.webkit.org/changeset/63684 might have broken GTK Linux 32-bit Release and Qt Linux Release
Comment 9 Csaba Osztrogonác 2010-07-19 22:30:23 PDT
(In reply to comment #8)
> http://trac.webkit.org/changeset/63684 might have broken GTK Linux 32-bit Release and Qt Linux Release

And all Mac bot. :(

fast/dom/Window/window-properties-expected.txt files updated in http://trac.webkit.org/changeset/63720