Bug 30447 - webcore.gyp needs a separate target for bindings
Summary: webcore.gyp needs a separate target for bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P1 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-16 10:59 PDT by sgk
Modified: 2009-10-16 13:38 PDT (History)
2 users (show)

See Also:


Attachments
Refactors .idl-generated bindings into a separate webcore_bindings target. (25.20 KB, patch)
2009-10-16 11:04 PDT, sgk
levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff
Update with TODOs changed to FIXMEs. (24.68 KB, patch)
2009-10-16 12:59 PDT, sgk
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sgk 2009-10-16 10:59:07 PDT
The gyp-generated Chromium build of webcore has been stretched to the breaking point:  http://crbug.com/23957
It needs to be made manageable by creating a separate target to build just the bindings into a library.
Comment 1 sgk 2009-10-16 11:04:14 PDT
Created attachment 41299 [details]
Refactors .idl-generated bindings into a separate webcore_bindings target.  

Ripple effect creation of a webcore_bindings_sources target, too.
Comment 2 Bradley Nelson 2009-10-16 11:48:02 PDT
This looks good.
It appears more drastic than it is because sgk reformatted a lots of long lines.
Comment 3 David Levin 2009-10-16 12:14:04 PDT
Comment on attachment 41299 [details]
Refactors .idl-generated bindings into a separate webcore_bindings target.  

WebKit uses FIXME instead of TODO (and never that I've seen with the FIXME(name): style).

So

s/TODO\((.*)\):/FIXME: $1 -/
s/TODO/FIXME/
Comment 4 sgk 2009-10-16 12:59:58 PDT
Created attachment 41313 [details]
Update with TODOs changed to FIXMEs.
Comment 5 David Levin 2009-10-16 13:22:53 PDT
Comment on attachment 41313 [details]
Update with TODOs changed to FIXMEs.

Largely a rubberstamp on my part (based on Bradley Nelson's review and my look over it).
Comment 6 WebKit Commit Bot 2009-10-16 13:37:55 PDT
Comment on attachment 41313 [details]
Update with TODOs changed to FIXMEs.

Clearing flags on attachment: 41313

Committed r49693: <http://trac.webkit.org/changeset/49693>
Comment 7 WebKit Commit Bot 2009-10-16 13:38:00 PDT
All reviewed patches have been landed.  Closing bug.