RESOLVED FIXED 30447
webcore.gyp needs a separate target for bindings 
https://bugs.webkit.org/show_bug.cgi?id=30447
Summary webcore.gyp needs a separate target for bindings
sgk
Reported 2009-10-16 10:59:07 PDT
The gyp-generated Chromium build of webcore has been stretched to the breaking point: http://crbug.com/23957 It needs to be made manageable by creating a separate target to build just the bindings into a library.
Attachments
Refactors .idl-generated bindings into a separate webcore_bindings target. (25.20 KB, patch)
2009-10-16 11:04 PDT, sgk 		levin: review+
levin: commit-queue-
DetailsFormatted DiffDiff
Update with TODOs changed to FIXMEs. (24.68 KB, patch)
2009-10-16 12:59 PDT, sgk 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
sgk
Comment 1 2009-10-16 11:04:14 PDT
Created attachment 41299 [details] Refactors .idl-generated bindings into a separate webcore_bindings target. Ripple effect creation of a webcore_bindings_sources target, too.
Bradley Nelson
Comment 2 2009-10-16 11:48:02 PDT
This looks good. It appears more drastic than it is because sgk reformatted a lots of long lines.
David Levin
Comment 3 2009-10-16 12:14:04 PDT
Comment on attachment 41299 [details] Refactors .idl-generated bindings into a separate webcore_bindings target. WebKit uses FIXME instead of TODO (and never that I've seen with the FIXME(name): style). So s/TODO\((.*)\):/FIXME: $1 -/ s/TODO/FIXME/
sgk
Comment 4 2009-10-16 12:59:58 PDT
Created attachment 41313 [details] Update with TODOs changed to FIXMEs.
David Levin
Comment 5 2009-10-16 13:22:53 PDT
Comment on attachment 41313 [details] Update with TODOs changed to FIXMEs. Largely a rubberstamp on my part (based on Bradley Nelson's review and my look over it).
WebKit Commit Bot
Comment 6 2009-10-16 13:37:55 PDT
Comment on attachment 41313 [details] Update with TODOs changed to FIXMEs. Clearing flags on attachment: 41313 Committed r49693: <http://trac.webkit.org/changeset/49693>
WebKit Commit Bot
Comment 7 2009-10-16 13:38:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.