The gyp-generated Chromium build of webcore has been stretched to the breaking point: http://crbug.com/23957 It needs to be made manageable by creating a separate target to build just the bindings into a library.
Created attachment 41299 [details] Refactors .idl-generated bindings into a separate webcore_bindings target. Ripple effect creation of a webcore_bindings_sources target, too.
This looks good. It appears more drastic than it is because sgk reformatted a lots of long lines.
Comment on attachment 41299 [details] Refactors .idl-generated bindings into a separate webcore_bindings target. WebKit uses FIXME instead of TODO (and never that I've seen with the FIXME(name): style). So s/TODO\((.*)\):/FIXME: $1 -/ s/TODO/FIXME/
Created attachment 41313 [details] Update with TODOs changed to FIXMEs.
Comment on attachment 41313 [details] Update with TODOs changed to FIXMEs. Largely a rubberstamp on my part (based on Bradley Nelson's review and my look over it).
Comment on attachment 41313 [details] Update with TODOs changed to FIXMEs. Clearing flags on attachment: 41313 Committed r49693: <http://trac.webkit.org/changeset/49693>
All reviewed patches have been landed. Closing bug.