WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
304415
Use NO_UNIQUE_ADDRESS macro instead of [[no_unique_address]] attribute
https://bugs.webkit.org/show_bug.cgi?id=304415
Summary
Use NO_UNIQUE_ADDRESS macro instead of [[no_unique_address]] attribute
Brandon
Reported
2025-12-18 08:54:19 PST
Windows builds with clang-cl fail to recognize [[no_unique_address]] even when compiling with C++23. WebKit already has a NO_UNIQUE_ADDRESS macro in Compiler.h that properly detects compiler support for this attribute and falls back to empty definition when unavailable. Replace direct use of [[no_unique_address]] with the NO_UNIQUE_ADDRESS macro in RefCounted base classes to fix Windows builds while maintaining the attribute on platforms that support it.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-12-18 08:54:25 PST
<
rdar://problem/166795977
>
Brandon
Comment 2
2025-12-18 08:55:39 PST
Pull request:
https://github.com/WebKit/WebKit/pull/55633
EWS
Comment 3
2025-12-18 11:24:28 PST
Committed
304697@main
(62df643698ea): <
https://commits.webkit.org/304697@main
> Reviewed commits have been landed. Closing PR #55633 and removing active labels.
ryosei.otaka
Comment 4
2025-12-18 22:12:59 PST
***
Bug 304411
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug