Bug 30434 - LayoutTests/fast/loader/local-JavaScript-from-local.html times out in case of error.
Summary: LayoutTests/fast/loader/local-JavaScript-from-local.html times out in case of...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-16 01:49 PDT by Yuzo Fujishima
Modified: 2009-10-16 13:21 PDT (History)
2 users (show)

See Also:


Attachments
call notifyDone in case of error (1.19 KB, patch)
2009-10-16 01:55 PDT, Yuzo Fujishima
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuzo Fujishima 2009-10-16 01:49:49 PDT
LayoutTests/fast/loader/local-JavaScript-from-local.html calls layoutTestController.waitUntilDone()
but doesn't call layoutTestController.notifyDone() if local script element load fails.
Comment 1 Yuzo Fujishima 2009-10-16 01:55:41 PDT
Created attachment 41277 [details]
call notifyDone in case of error
Comment 2 Yuzo Fujishima 2009-10-16 01:57:32 PDT
Can anyone review the above 2-line patch?

Yuzo
Comment 3 Eric Seidel (no email) 2009-10-16 13:06:00 PDT
Comment on attachment 41277 [details]
call notifyDone in case of error

Yuzo isn't a committer, so marking this cq+.
Comment 4 WebKit Commit Bot 2009-10-16 13:21:19 PDT
Comment on attachment 41277 [details]
call notifyDone in case of error

Clearing flags on attachment: 41277

Committed r49691: <http://trac.webkit.org/changeset/49691>
Comment 5 WebKit Commit Bot 2009-10-16 13:21:23 PDT
All reviewed patches have been landed.  Closing bug.