WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
30429
Web Inspector: [REGRESSION] Tabbing Through Element Attributes Loses Focus Immediately
https://bugs.webkit.org/show_bug.cgi?id=30429
Summary
Web Inspector: [REGRESSION] Tabbing Through Element Attributes Loses Focus Im...
Joseph Pecoraro
Reported
2009-10-15 22:07:35 PDT
This is bizarre. When tabbing to create a new element it loses focus immediately. I don't know when this regression happened I haven't looked into the past. Stepping through the code the following happens: Start editing an attribute and push tab: 1. It properly adds a new attribute or starts editing the next attribute 2. It seems to set the focus on the new node 3. It properly sets the selection in the new node 4. The moment it returns from the blur event listener in WebInspector.startEditing() the focus on the new node disappears. I haven't seen anything like this. Any ideas?
Attachments
Proposed Patch
(2.80 KB, patch)
2009-10-29 12:27 PDT
,
Timothy Hatcher
pfeldman
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Timothy Hatcher
Comment 1
2009-10-29 11:02:22 PDT
This happens because commiting an attribute edit causes a delayed callback to happen (WebInspector.DOMAgent.prototype._didApplyDomChange) which then calls _updateTitle on the ElementsTreeElement that changed, which sets innerHTML, which fires a blur event, and that cancels the edit for the next attribute.
Timothy Hatcher
Comment 2
2009-10-29 12:23:05 PDT
I have a fix.
Timothy Hatcher
Comment 3
2009-10-29 12:27:05 PDT
Created
attachment 42125
[details]
Proposed Patch
Timothy Hatcher
Comment 4
2009-10-29 14:59:59 PDT
Committed
r50303
: <
http://trac.webkit.org/changeset/50303
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug