Bug 30426 - WebKitTools/Scripts/check-webkit-style incorrect complains about unindented code within namespaces in header files
Summary: WebKitTools/Scripts/check-webkit-style incorrect complains about unindented c...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-10-15 21:33 PDT by James Robinson
Modified: 2009-10-15 22:03 PDT (History)
2 users (show)

See Also:

Fixes the script (6.48 KB, patch)
2009-10-15 21:39 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2009-10-15 21:33:21 PDT
The WebKit style guide now says that code inside namespaces should not be indented even if it's inside a header file (thank $Deity)!  However, check-webkit-style is out of date and still whines about it.
Comment 1 James Robinson 2009-10-15 21:39:49 PDT
Created attachment 41265 [details]
Fixes the script
Comment 2 David Levin 2009-10-15 21:51:04 PDT
fyi, I just r+ a fix for the same issue (namespace indentation) that was pretty minimal in scope (https://bugs.webkit.org/show_bug.cgi?id=30426). I still think there is a lot of value on what you did here with some fixes as mentioned above. You can still basically replace the code as you are doing.
Comment 3 David Levin 2009-10-15 21:51:33 PDT
Ugh. Ignore my previous comment. It was meant for another bug.
Comment 4 WebKit Commit Bot 2009-10-15 22:03:50 PDT
Comment on attachment 41265 [details]
Fixes the script

Clearing flags on attachment: 41265

Committed r49669: <http://trac.webkit.org/changeset/49669>
Comment 5 WebKit Commit Bot 2009-10-15 22:03:53 PDT
All reviewed patches have been landed.  Closing bug.