RESOLVED FIXED304256
[cleanup] Modernize first/lastLineBaseline functions (RenderTable, RenderTableSection, RenderGrid and RenderFlexibleBox) 
https://bugs.webkit.org/show_bug.cgi?id=304256
Summary [cleanup] Modernize first/lastLineBaseline functions (RenderTable, RenderTabl...
alan
Reported 2025-12-16 08:31:20 PST
ssia
Attachments
Patch (15.51 KB, patch)
2025-12-16 08:34 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (15.50 KB, patch)
2025-12-16 08:53 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (18.12 KB, patch)
2025-12-16 10:34 PST, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (18.12 KB, patch)
2025-12-16 11:03 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2025-12-16 08:34:10 PST
Created attachment 477750 [details] Patch
alan
Comment 2 2025-12-16 08:53:54 PST
Created attachment 477751 [details] Patch
alan
Comment 3 2025-12-16 10:34:27 PST
Created attachment 477753 [details] Patch
Antti Koivisto
Comment 4 2025-12-16 10:40:02 PST
Comment on attachment 477753 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=477753&action=review > Source/WebCore/rendering/RenderTable.cpp:1622 > + return baseline ? std::make_optional(topNonEmptySection->logicalTop().toInt() + *baseline) : std::nullopt; maybe std::make_optional can be just std::optional?
alan
Comment 5 2025-12-16 11:03:57 PST
Created attachment 477754 [details] [fast-cq]Patch
EWS
Comment 6 2025-12-16 13:38:37 PST
Committed 304539@main (1a7ed8b60310): <https://commits.webkit.org/304539@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 477754 [details].
Radar WebKit Bug Importer
Comment 7 2025-12-16 13:39:11 PST
<rdar://problem/166644167>
Note You need to log in before you can comment on or make changes to this bug.