Bug 30425 - Compositing layers not correctly updated after partial layout
Summary: Compositing layers not correctly updated after partial layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-15 21:13 PDT by Simon Fraser (smfr)
Modified: 2009-10-18 10:18 PDT (History)
0 users

See Also:


Attachments
Testcase (1.07 KB, text/html)
2009-10-15 21:13 PDT, Simon Fraser (smfr)
no flags Details
WIP patch (5.92 KB, patch)
2009-10-15 21:34 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (10.70 KB, patch)
2009-10-18 09:52 PDT, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-10-15 21:13:05 PDT
Created attachment 41263 [details]
Testcase

When a partial layout happens (with a non-null subroot), some compositing layers can be left un-updated, and thus display in the wrong positions. This happens because RenderLayerBacking::updateAfterLayout() assumes that some parent layer is going to update the geometry this layer, but, in the case of a partial layout, the parent layer may not be affected by layout.
Comment 1 Simon Fraser (smfr) 2009-10-15 21:34:52 PDT
Created attachment 41264 [details]
WIP patch
Comment 2 Simon Fraser (smfr) 2009-10-18 09:52:39 PDT
Created attachment 41380 [details]
Patch
Comment 3 mitz 2009-10-18 10:04:07 PDT
Comment on attachment 41380 [details]
Patch

> +        When a partial layout happend, for example as the result of a postion-change-only

Typo: happend.

r=me
Comment 4 Simon Fraser (smfr) 2009-10-18 10:18:03 PDT
http://trac.webkit.org/changeset/49753