This if statement should evaluate to false if applicationCache is disabled at runtime: if ('applicationCache' in window) You can look at https://bugs.webkit.org/show_bug.cgi?id=30240 for an example of how this was done for window.Audio(). We probably need to move this setting out of WebCore::Settings and into a global static so it's easily accessible from the V8 bindings.
Created attachment 42497 [details] Proposed fix
Comment on attachment 42497 [details] Proposed fix > Index: WebCore/ChangeLog > + Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures. There is a TAB in the changelog that needs to be removed. Nice start, but this is incomplete as discussed.
Created attachment 42499 [details] Revised fix
Comment on attachment 42499 [details] Revised fix > Index: WebCore/ChangeLog > + Just adding a bit, so new tests. I think you have not really changed the visible functionality so no new tests. > Index: WebCore/bindings/v8/custom/V8CustomBinding.h > #if ENABLE(OFFLINE_WEB_APPLICATIONS) > + DECLARE_ACCESSOR_RUNTIME_ENABLER(DOMApplicationCache); Another TAB to remove. I can fix this on landing.
Committed as http://trac.webkit.org/changeset/50534.