Bug 304105 – Expose `FECOMPOSITE_OPERATOR_LIGHTER` to WebIDL Interface and update it as highest enum value

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Ahmad Saleem]

Hi Team,

While trying to look for reason, why we fail following test: https://wpt.fyi/results/svg/types/scripted/SVGAnimatedEnumeration-SVGFECompositeElement.html?label=master&label=experimental&aligned

It seems that it is because of `FECOMPOSITE_OPERATOR_LIGHTER` being exposed in IDL for Firefox but not in Chrome / Blink and Safari / WebKit.

Web Specification: https://drafts.csswg.org/filter-effects-1/#InterfaceSVGFECompositeElement

WebKit: https://github.com/WebKit/WebKit/blob/462ddb30dffca856c17d210c957f46906455298f/Source/WebCore/svg/SVGFECompositeElement.idl#L37

Blink / Chromium: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/svg/svg_fe_composite_element.idl;l=38;drc=e04c80528ebfd7eeca80306f5ccfcb27d9acf5e8

Gecko / Firefox: https://searchfox.org/firefox-main/rev/96eccf5af235e2f592e45fda4e79e6194448fc74/dom/webidl/SVGFECompositeElement.webidl#24

^ Notice that Gecko has `const unsigned short SVG_FECOMPOSITE_OPERATOR_LIGHTER = 7;`.

In case, if we have to fix, we need to add it to IDL and also update:

https://github.com/WebKit/WebKit/blob/462ddb30dffca856c17d210c957f46906455298f/Source/WebCore/svg/SVGFECompositeElement.h#L33

from:

CompositeOperationType::FECOMPOSITE_OPERATOR_ARITHMETIC

to:

CompositeOperationType::FECOMPOSITE_OPERATOR_LIGHTER

____________

Just raising, so we can fix it. It progress WPT, just to let know.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/166704079>

[Taher]

We may need to manually fix the test-case `LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html` because it's expecting a throw.

[Robert Longson]

See https://github.com/w3c/svgwg/issues/424

[Karl Dubost]

yes specifically 
https://github.com/w3c/svgwg/issues/424#issuecomment-3194765718

[Taher]

Pull request: https://github.com/WebKit/WebKit/pull/55841

[EWS]

Committed 304941@main (89a77dce2e2a): <https://commits.webkit.org/304941@main>

Reviewed commits have been landed. Closing PR #55841 and removing active labels.