Bug 30407 – HTML 5 media elements should set network state to NETWORK_EMPTY if they do not have a source

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Andrew Scherkus]

Latest spec reads:
"Otherwise the media element has neither a src attribute nor a source element child: set the networkState to NETWORK_EMPTY, and abort these steps; the synchronous section ends."
http://www.whatwg.org/specs/web-apps/current-work/#concept-media-load-algorithm

I also updated the comments to match the steps outlined in the spec.

[Andrew Scherkus]

Created attachment 41246 [details]
Round 1

[Andrew Scherkus]

Comment on attachment 41246 [details]
Round 1

Digging around some more I found more bugs... I'll keep working on this patch.

[Andrew Scherkus]

Created attachment 41255 [details]
Round 2

Few things (as mentioned in the patch):
  - Having no source is defined as a null src attribute and no <source> children, and should result in the element going to NETWORK_EMPTY
  - Empty string "" is considered a valid src attribute and should be loaded (before it slipped through the cracks and the element would get jammed in NETWORK_LOADING)

[Andrew Scherkus]

Created attachment 41256 [details]
Round 3

Removed useless findMediaElement() line from video-src-empty.html

[Eric Seidel (no email)]

CCing the media master.

[Eric Carlson]

Comment on attachment 41256 [details]
Round 3


> +        <p>Empty src attribute defined.  Valid URL and video should error.</p>

I think you meant to say "Invalid URL"

r=me with this change.

Thanks for catching this!

[Andrew Scherkus]

Created attachment 41330 [details]
Round 4

Valid -> Invalid

[WebKit Commit Bot]

Comment on attachment 41330 [details]
Round 4

Clearing flags on attachment: 41330

Committed r49702: <http://trac.webkit.org/changeset/49702>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.