RESOLVED FIXED 30404
Web Inspector: Prevent subsequent tests from failing upon inspector test timeout. 
https://bugs.webkit.org/show_bug.cgi?id=30404
Summary Web Inspector: Prevent subsequent tests from failing upon inspector test time...
Pavel Feldman
Reported 2009-10-15 13:55:00 PDT
When something is broken badly in the front-end, inspector test might timeout. As a result, tear down won't happen and inspector window will stay open. As a result all subsequent tests relying upon 800x600 will fail.
Attachments
[PATCH] Short term fix (1.59 KB, patch)
2009-10-15 14:11 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-10-15 14:11:34 PDT
Created attachment 41245 [details] [PATCH] Short term fix This is a short term fix. Right one is to make sure that inspector is closed after the test it was opened for, but that requires additional state in LayoutTestController.
Timothy Hatcher
Comment 2 2009-10-15 14:14:42 PDT
Comment on attachment 41245 [details] [PATCH] Short term fix > + alert("Internal timeout exceeded.") Maybe console.log would be better?
Pavel Feldman
Comment 3 2009-10-15 14:25:59 PDT
(In reply to comment #2) > (From update of attachment 41245 [details]) > > > + alert("Internal timeout exceeded.") > > Maybe console.log would be better? They both transform into a text line in the DRT dump. I hesitate to use console since it will also trigger some inspector bits and by this time we know inspector is broken. Anyway, I am not closing this bug since the right solution is on its way...
Timothy Hatcher
Comment 4 2009-10-15 14:27:33 PDT
Ok, alert() is fine.
Pavel Feldman
Comment 5 2009-10-15 14:39:17 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/evaluate-in-frontend.js Committed r49656
Note You need to log in before you can comment on or make changes to this bug.