Bug 30404 - Web Inspector: Prevent subsequent tests from failing upon inspector test timeout.
Summary: Web Inspector: Prevent subsequent tests from failing upon inspector test time...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-15 13:55 PDT by Pavel Feldman
Modified: 2009-11-08 08:20 PST (History)
1 user (show)

See Also:

Attachments
[PATCH] Short term fix (1.59 KB, patch)
2009-10-15 14:11 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-10-15 13:55:00 PDT 
When something is broken badly in the front-end, inspector test might timeout. As a result, tear down won't happen and inspector window will stay open. As a result all subsequent tests relying upon 800x600 will fail.
Comment 1 Pavel Feldman 2009-10-15 14:11:34 PDT 
Created attachment 41245 [details]
[PATCH] Short term fix

This is a short term fix. Right one is to make sure that inspector is closed after the test it was opened for, but that requires additional state in LayoutTestController.
Comment 2 Timothy Hatcher 2009-10-15 14:14:42 PDT 
Comment on attachment 41245 [details]
[PATCH] Short term fix


> +        alert("Internal timeout exceeded.")

Maybe console.log would be better?
Comment 3 Pavel Feldman 2009-10-15 14:25:59 PDT 
(In reply to comment #2)
> (From update of attachment 41245 [details])
> 
> > +        alert("Internal timeout exceeded.")
> 
> Maybe console.log would be better?

They both transform into a text line in the DRT dump. I hesitate to use console since it will also trigger some inspector bits and by this time we know inspector is broken.

Anyway, I am not closing this bug since the right solution is on its way...
Comment 4 Timothy Hatcher 2009-10-15 14:27:33 PDT 
Ok, alert() is fine.
Comment 5 Pavel Feldman 2009-10-15 14:39:17 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/inspector/evaluate-in-frontend.js
Committed r49656