Bug 30399 – <mask> and <pattern> don't handle texts

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Dirk Schulze]

Created attachment 41236 [details]
Mask with text

Texts in maks are ignored. I thougt that Eric already opened a bug about masking and texts but I couldn't find it.

I added a short example. If mask works correctly, you should see a green squarre with the red text "Mask" on it.

[Dirk Schulze]

*** Bug 15655 has been marked as a duplicate of this bug. ***

[Dirk Schulze]

The problem is in renderSubtreeToImage() (SVGRenderSupport.cpp). We set the paintInfo.rect to en empty IntRect.

    RenderObject::PaintInfo info(image->context(), IntRect(), PaintPhaseForeground, 0, 0, 0);

This causes problems in RenderSVGText::paint(). RenderSVGText::paint() calls

    RenderBlock::paint(pi, 0, 0);

and RenderBlock::paint intersects visibleOverflowRect() with paintInfo.rect and returns if this intersection is empty. But even disabling the return for testing didn't solve the problem. I had to add the paintInfo.rect of the SVGResource and the renderer with the relation to this resource to renderSubtreeToImage() manually to get texts working. Sounds a bit complicated atm :-P

[Nikolas Zimmermann]

(In reply to comment #2)
> The problem is in renderSubtreeToImage() (SVGRenderSupport.cpp). We set the
> paintInfo.rect to en empty IntRect.
> 
>     RenderObject::PaintInfo info(image->context(), IntRect(),
> PaintPhaseForeground, 0, 0, 0);
> 
> This causes problems in RenderSVGText::paint(). RenderSVGText::paint() calls
> 
>     RenderBlock::paint(pi, 0, 0);
> 
> and RenderBlock::paint intersects visibleOverflowRect() with paintInfo.rect and
> returns if this intersection is empty. But even disabling the return for
> testing didn't solve the problem. I had to add the paintInfo.rect of the
> SVGResource and the renderer with the relation to this resource to
> renderSubtreeToImage() manually to get texts working. Sounds a bit complicated
> atm :-P

Yeah, it's a bit involved. We need to fix SVG text renderers first, otherwhise there will be no clean solution available.

[Dirk Schulze]

Works in trunk. Closing bug.