RESOLVED FIXED30386
Crash due to JSVALUE32_64 on 64-bit Windows 
https://bugs.webkit.org/show_bug.cgi?id=30386
Summary Crash due to JSVALUE32_64 on 64-bit Windows
Tor Arne Vestbø
Reported 2009-10-15 07:37:12 PDT
We're seeing crashes on 64-bit windows when JSVALUE32_64 is defined. I'm guessing we should enable JSVALUE_64 on windows too (this does not crash), by changing the line in Platform.h from #if PLATFORM(X86_64) && (PLATFORM(DARWIN) || PLATFORM(LINUX)) to just #if PLATFORM(X86_64) ? http://gist.github.com/210972 What do you think Geoffrey?
Attachments
Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2009-10-15 10:42:19 PDT
Yeah, you want JSVALUE64. I'd just change this: #if PLATFORM(X86_64) && (PLATFORM(DARWIN) || PLATFORM(LINUX)) to this: #if PLATFORM(X86_64) && (PLATFORM(DARWIN) || PLATFORM(LINUX) || PLATFORM(WIN_OS)) I don't think you need the COMPILER(MINGW) case inside the 64-bit case.
Note You need to log in before you can comment on or make changes to this bug.