RESOLVED FIXED303768
JSPromiseConstructor.cpp should include ObjectConstructor.h 
https://bugs.webkit.org/show_bug.cgi?id=303768
Summary JSPromiseConstructor.cpp should include ObjectConstructor.h
Vassili Bykov
Reported 2025-12-08 11:41:46 PST
The recent PR for https://bugs.webkit.org/show_bug.cgi?id=303603 added code to JSPromiseConstructor.cpp that uses the function `constructEmptyObject()` defined in ObjectConstructor.h. That file is not explicitly included by JSPromiseConstructor.cpp, which causes spurious build failures if the .cpp file ends up in unified sources in a context that doesn't have the required definitions.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2025-12-08 11:41:52 PST
<rdar://problem/166079243>
Vassili Bykov
Comment 2 2025-12-08 11:44:35 PST
Pull request: https://github.com/WebKit/WebKit/pull/55051
EWS
Comment 3 2025-12-08 12:36:56 PST
Committed 304109@main (ac6a27e1c512): <https://commits.webkit.org/304109@main> Reviewed commits have been landed. Closing PR #55051 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.