Bug 30376 – Web Inspector: Create and update frontend script objects only when web inspector is visible.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

All script objects should exist between populateScriptObjects and releaseScriptObjects (i.e. when web inspector window is visible). Replace a number of checks for m_frontend being defined with windowVisible. That actually fixes the following crash:

1. Open a page that has console output
2. Open and close web inspector for it
3. Refresh the page

Console objects were pushed into the web inspector behind the m_frontend check (that was not enough).

I actually think we should simplify the code and dispose the view (along with the m_frontend) when inspector window is closed. I don't like the state of InspectorController when m_frontend (along with the frontend scripts) exists while window is not visible. We are anyway not talking to frontend when it is not viisble.

The downside of disposing frontend is that inspector would loose its state when re-opened. We already maintain active tab state though, so it won't be too bad. What do you think?

[Pavel Feldman]

Created attachment 41207 [details]
patch

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorController.cpp
Committed r49614