Bug 30374 - [GStreamer] Doesn't check if caps are valid in ::naturalSize()
Summary: [GStreamer] Doesn't check if caps are valid in ::naturalSize()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-14 21:16 PDT by Sebastian Dröge (slomo)
Modified: 2009-10-15 06:25 PDT (History)
1 user (show)

See Also:

Attachments
0003-Check-if-caps-are-valid-before-parsing-them.patch (2.43 KB, patch)
2009-10-14 21:18 PDT, Sebastian Dröge (slomo) 		no flags Details | Formatted Diff | Diff
0003-Check-if-caps-are-valid-before-parsing-them.patch (2.47 KB, patch)
2009-10-14 22:49 PDT, Sebastian Dröge (slomo) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Dröge (slomo) 2009-10-14 21:16:05 PDT 
...which leads to assertions:

GStreamer-CRITICAL **: gst_caps_is_fixed: assertion `GST_IS_CAPS (caps)' failed
aborting...


Attached trivial patch fixes this.
Comment 1 Sebastian Dröge (slomo) 2009-10-14 21:18:10 PDT 
Created attachment 41204 [details]
0003-Check-if-caps-are-valid-before-parsing-them.patch
Comment 2 Sebastian Dröge (slomo) 2009-10-14 21:18:39 PDT 
Can be reproduced with http://people.freedesktop.org/~company/stuff/video-demo.html for example
Comment 3 Sebastian Dröge (slomo) 2009-10-14 22:49:00 PDT 
Created attachment 41209 [details]
0003-Check-if-caps-are-valid-before-parsing-them.patch

Updated patch, we also need to check for *fixed* caps there.
Comment 4 WebKit Commit Bot 2009-10-15 06:25:42 PDT 
Comment on attachment 41209 [details]
0003-Check-if-caps-are-valid-before-parsing-them.patch

Clearing flags on attachment: 41209

Committed r49622: <http://trac.webkit.org/changeset/49622>
Comment 5 WebKit Commit Bot 2009-10-15 06:25:45 PDT 
All reviewed patches have been landed.  Closing bug.