Bug 303645 – [Tools][WPE][GTK][SDK] Build webkit in a common directory at /sdk/webkit when using the SDK

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Carlos Alberto Lopez Perez]

Since we moved out of flatpak SDK we miss the feature that it had of building webkit in /app/webkit, as that allowed reusing remote caches (ccache, sccache) when developers or bots have the webkit checkout in different directories very easy

I tried a workaround for ccache at bug 301003 but that ended causing issues with GDB and the paths to the source files.

Also for sccache that workaround is not possible, sccache does not have the ccache feature of CCACHE_BASEDIR. See https://github.com/mozilla/sccache/issues/35

So the idea here is the following:

1. When using the SDK <https://github.com/Igalia/webkit-container-sdk> create a symlink from /sdk/webkit to the current directory.
2. When building webkit create a private mount namespace that bind mounts /sdk/webkit  to the current webkit source directory and that is private to the process building, so there can be multiple webkit builds (for eample a user that builds webkit at the same time from different dirs), each one with its own private  /sdk/webkit mount without interfering between them.

Later in the SDK we would need support for recreating the symlink without using build-webkit for use cases like doing tests in a directory different than the build one without having to trigger build-webkit again so it does that.

[Carlos Alberto Lopez Perez]

Pull request: https://github.com/WebKit/WebKit/pull/54941

[EWS]

Committed 304672@main (6511e21704cb): <https://commits.webkit.org/304672@main>

Reviewed commits have been landed. Closing PR #54941 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/166784579>

[Fujii Hironori]

test-webkitperl is failing after 304672@main.
https://build.webkit.org/#/builders/40/builds/24297

> Cannot find jsc, try with --release or specify with --jsc <path>.
> #   Failed test 'test262 test failed, ignore expectations (new failures: 2)'
> #   at Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl line 142.
> #          got: '0'
> #     expected: '2'
> Cannot find jsc, try with --release or specify with --jsc <path>.

[Fujii Hironori]

(In reply to Fujii Hironori from comment #4)
> test-webkitperl is failing after 304672@main.

bug#304614 is the ticket.