Bug 30340 - Make fast/css/opacity-float.html use the script-test approach
Summary: Make fast/css/opacity-float.html use the script-test approach
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Evan Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-13 14:38 PDT by Evan Martin
Modified: 2009-11-14 08:54 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2009-10-13 14:38:18 PDT
Darin says:

In the future, you should use the script-tests approach to build tests like
this. This style of tests that write out more about what they're testing and
why they pass that you get automatically from that are superior. A good example
of how to do this sort of test is
LayoutTests/fast/dom/HTMLFormElement/script-tests/elements-not-in-document.js
and you may be able to see from that how this test could have been done that
way.
Comment 1 Evan Martin 2009-10-13 14:49:52 PDT
Also, while I'm fixing it:

>     - change the test to use script-tests for better clarity
>     - add quite a few more kinds of numbers to the test cases
>     - test all the different types of units -- a test should fail if we made
> any mistakes in the switch statements

I guess that maybe should be a new test, which is a general "test CSS unit formatting" test.