RESOLVED FIXED303398
[RenderStyleGen] Generate getter/setter functions that were missed due to being implemented in RenderStyle.h 
https://bugs.webkit.org/show_bug.cgi?id=303398
Summary [RenderStyleGen] Generate getter/setter functions that were missed due to bei...
Sam Weinig
Reported 2025-12-02 09:20:18 PST
A few properties were missed due to their implementations being inline in RenderStyle.h.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2025-12-02 10:35:33 PST
Pull request: https://github.com/WebKit/WebKit/pull/54710
EWS
Comment 2 2025-12-02 18:50:14 PST
Committed 303805@main (8aa1e5bdbca5): <https://commits.webkit.org/303805@main> Reviewed commits have been landed. Closing PR #54710 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2025-12-02 18:51:13 PST
<rdar://problem/165733843>
Diego Pino
Comment 4 2025-12-04 01:18:35 PST
Re-opening for pull request https://github.com/WebKit/WebKit/pull/54827
Diego Pino
Comment 5 2025-12-04 01:29:28 PST
The 'GTK-Linux-64-bit-Release-Debian-Stable-Build' bot fails with the following error: https://build.webkit.org/#/builders/46/builds/58096/steps/9/logs/stdio ``` WebCore/PrivateHeaders/WebCore/RenderStyleInlines.h: In member function ‘constexpr bool WebCore::RenderStyle::isDisplayRegionType() const’: WebCore/PrivateHeaders/WebCore/RenderStyleInlines.h:228:19: error: call to non-‘constexpr’ function ‘WebCore::DisplayType WebCore::RenderStyle::display() const’ 228 | return display() == DisplayType::Block ``` GCC12 and lower are more strict with regard to declaration of functions as constexpr.
Lauro Moura
Comment 6 2025-12-04 05:04:22 PST
*** Bug 303504 has been marked as a duplicate of this bug. ***
EWS
Comment 7 2025-12-04 09:09:29 PST
Committed 303918@main (aa9410d1ed64): <https://commits.webkit.org/303918@main> Reviewed commits have been landed. Closing PR #54827 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.