Bug 303383 – Crash in RTCEncodedStreamProducer::writeFrame, m_transformBackend nullptr

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Kimmo Kinnunen]

Crash in RTCEncodedStreamProducer::writeFrame, m_transformBackend nullptr
https://build.webkit.org/results/Apple-Tahoe-Debug-WK2-Tests/303542@main%20(290)/impo[…]oded-transform/script-metadata-transform.https-crash-log.txt
https://build.webkit.org/results/Apple-Tahoe-Debug-WK2-Tests/303542@main%20(290)/results.html
I'm pretty sure it can be fixed by
diff --git a/Source/WebCore/Modules/mediastream/RTCEncodedStreamProducer.cpp b/Source/WebCore/Modules/mediastream/RTCEncodedStreamProducer.cpp
index fc452c545d17..183e89eada5d 100644
--- a/Source/WebCore/Modules/mediastream/RTCEncodedStreamProducer.cpp
+++ b/Source/WebCore/Modules/mediastream/RTCEncodedStreamProducer.cpp
@@ -142,6 +142,9 @@ ExceptionOr<void> RTCEncodedStreamProducer::writeFrame(ScriptExecutionContext& c
     auto* globalObject = context.globalObject();
     if (!globalObject)
         return { };
+    RefPtr backend = m_transformBackend;
+    if (!backend)
+        return { }; // should  we return exception if clear()'ed
 
     Ref vm = globalObject->vm();
     auto scope = DECLARE_THROW_SCOPE(vm);
@@ -156,10 +159,9 @@ ExceptionOr<void> RTCEncodedStreamProducer::writeFrame(ScriptExecutionContext& c
     }, [&](RefPtr<RTCEncodedVideoFrame>& value) {
         return value->rtcFrame(vm);
     });
-
     // If no data, skip the frame since there is nothing to packetize or decode.
     if (rtcFrame->data().data())
-        Ref { *m_transformBackend }->processTransformedFrame(rtcFrame.get());
+        backend->processTransformedFrame(rtcFrame.get());
 
     return { };

[Radar WebKit Bug Importer]

<rdar://problem/165687266>

[youenn fablet]

Pull request: https://github.com/WebKit/WebKit/pull/54833

[EWS]

Committed 303908@main (8b20220f4c45): <https://commits.webkit.org/303908@main>

Reviewed commits have been landed. Closing PR #54833 and removing active labels.