currently csm are not working in qgwv ...
Created attachment 41106 [details] patch 0.1
Created attachment 41110 [details] patch 0.2 - same as 0.1, but not leaky
Comment on attachment 41110 [details] patch 0.2 - same as 0.1, but not leaky Argh, I'm sorry Antonio, I overlooked two details about the patch :-/ > + if (QGraphicsSceneContextMenuEvent* ev = static_cast<QGraphicsSceneContextMenuEvent*>(event)) { This if (and scope) isn't necessary, as the cast can't fail and as event is guaranteed to be non-zero. > + QContextMenuEvent fakeEvent(QContextMenuEvent(QContextMenuEvent::Mouse, ev->pos().toPoint())); It looks like there's a redundant nesting :), i.e. the could should probably read QContextMenuEvent fakeEvent(reason, ev->pos().toPoint()); instead of QContextMenuEvent fakeEvent(QContextMenuEvent(...)); I also think we should map ev->reason() to the QContextMenuEvent::Reason. Sorry :-/, I should've spotted this on the first review.
Created attachment 41144 [details] landed in r49618 - patch 0.3 > Argh, I'm sorry Antonio, I overlooked two details about the patch :-/ > I should've spotted this on the first review. thx again for re-reviewing, simon. > > + if (QGraphicsSceneContextMenuEvent* ev = static_cast<QGraphicsSceneContextMenuEvent*>(event)) { > This if (and scope) isn't necessary, as the cast can't fail and as event is > guaranteed to be non-zero. totally agree. done ... > > + QContextMenuEvent fakeEvent(QContextMenuEvent(QContextMenuEvent::Mouse, ev->pos().toPoint())); > It looks like there's a redundant nesting :), i.e. the could should probably > read errr ... likely copy and paste error. fixed. > I also think we should map ev->reason() to the QContextMenuEvent::Reason. true. also done.
Comment on attachment 41144 [details] landed in r49618 - patch 0.3 Thanks!
landed in r49618
Comment on attachment 41144 [details] landed in r49618 - patch 0.3 clearing r+ flag since patch has landed.
*** Bug 29180 has been marked as a duplicate of this bug. ***