Bug 30334 - Collect scope properties only when they are needed for completion
Summary: Collect scope properties only when they are needed for completion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-13 08:21 PDT by Yury Semikhatsky
Modified: 2009-10-15 09:57 PDT (History)
3 users (show)

See Also:

Attachments
patch (5.39 KB, patch)
2009-10-13 08:50 PDT, Yury Semikhatsky 		commit-queue: review-
pfeldman: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2009-10-13 08:21:14 PDT 
Collect scope properties only when they are needed for completion. There is no need need to serialize and pass them proactively along with call frames. This way all code collecting completion properties will live in InjectedScript.js
Comment 1 Yury Semikhatsky 2009-10-13 08:50:40 PDT 
Created attachment 41104 [details]
patch
Comment 2 Pavel Feldman 2009-10-13 08:58:41 PDT 
Looks good. Thanks for doing this!
Comment 3 WebKit Commit Bot 2009-10-13 09:55:02 PDT 
Comment on attachment 41104 [details]
patch

Rejecting patch 41104 from review queue.

pfeldman@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Comment 4 WebKit Commit Bot 2009-10-14 02:05:25 PDT 
Comment on attachment 41104 [details]
patch

Rejecting patch 41104 from review queue.

pfeldman@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Comment 5 Pavel Feldman 2009-10-14 02:17:41 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
Committed r49557
Comment 6 Eric Seidel (no email) 2009-10-15 09:57:00 PDT 
I've restarted the commit-queue, so it should notice the updated commitsers.py and you shouldn't have troubles like this again.