Bug 303244 – [cleanup] Rename IFC's blockLevelContent to blockContent

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[alan]

ssia

[alan]

Created attachment 477558 [details]
Patch

[Antti Koivisto]

Comment on attachment 477558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=477558&action=review

> Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp:184
>  LeafBoxIterator LineBox::blockLevelBox() const

should this also be just blockBox()?

[Antti Koivisto]

Comment on attachment 477558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=477558&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:3794
>      for (auto box = InlineIterator::firstRootInlineBoxFor(*this); box; box.traverseInlineBoxLineRightward()) {
>          auto lineBox = box->lineBox();
> -        if (lineBox->hasBlockLevelContent()) {
> -            hasBlockLevelContent = true;
> +        if (lineBox->hasBlockContent()) {
> +            hasBlockContent = true;
>              continue;
>          }

you need to update, this function is not here anymore

[alan]

Created attachment 477560 [details]
[fast-cq]Patch

[alan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 477558 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=477558&action=review
> 
> > Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp:184
> >  LeafBoxIterator LineBox::blockLevelBox() const
> 
> should this also be just blockBox()?

"block box" is a spec term for block level elements that are also block containers elements (e.g. <div>foobar</div>) and we have non-containers here too (.e.g <img style="display: block">) . (though we kinda diverged from the spec with "block level box" in  [block-in-inline]  too).

[EWS]

Committed 303639@main (7a673e1b74da): <https://commits.webkit.org/303639@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 477560 [details].

[Radar WebKit Bug Importer]

<rdar://problem/165553358>