See screenshot on http://code.google.com/p/chromium/issues/detail?id=23113 . The code is obviously wrong, and easy to fix.
Created attachment 41077 [details] fixerate
Comment on attachment 41077 [details] fixerate I'm not sure what I need to do about pixel baselines. Any advice?
Created attachment 41079 [details] fixerate
Created attachment 41115 [details] fix the bug and add a layout test
Note that this test includes a .png baseline (for Mac) and some UTF-8 (for the Arabic text). Not sure those make it through the patch process. :(
If you use svn-create-patch, it will base64 encode the png into the patch file. Maybe there's something that can do the same for git diffs?
https://bugs.webkit.org/show_bug.cgi?id=26830 :~(
Created attachment 41122 [details] fix the bug and note it's covered by an existing test
Comment on attachment 41122 [details] fix the bug and note it's covered by an existing test I realized that another test actually exhibits the problem too -- the baseline (in the Chrome tree) is wrong.
Comment on attachment 41122 [details] fix the bug and note it's covered by an existing test Rejecting patch 41122 from review queue. dimich@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Comment on attachment 41122 [details] fix the bug and note it's covered by an existing test Commit Bot has old version of committers.py... heh. Fixing up the flags, will land manually.
I've seen committers add themselves to the commit bot script without review, too.
Landed: http://trac.webkit.org/changeset/49540
Comment on attachment 41122 [details] fix the bug and note it's covered by an existing test I've restarted the commit-queue, so it should now correctly notice the update to committers.py and dimich@chromium.org should be able to set cq+ w/o problems. If you have any other issues, just drop me a line.