Bug 303174 – [Tools][GTK][browserperfdash-benchmark] browser-binary-size plan plugin fails to find the browser libraries in the GTK performance bot

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Carlos Alberto Lopez Perez]

On the GTK performance bot there is this situation:

$ ls -l /home/buildbot-worker/GTK-Linux-64-bit-Release-Build/build
lrwxrwxrwx 1 root root 57 Nov  6 01:13 /home/buildbot-worker/GTK-Linux-64-bit-Release-Build/build -> /home/buildbot/worker/GTK-Linux-64-bit-Release-Perf/build


which is basically a symlink from the directory that the GTK builder uses to the the directory where the GTK perf bot runs the tests.


The GTK perf bot doesn't build, so it downloads the binaries from the GTK builder.

And those can be resolved with this symlink.

So the LD_LIBRARY_PATH value that the tester set doesn't have effect because the DT_NEEDED entry is a full path and valid (the symlink resolves)

So that tricks the plugin to think that such library is outside of the build directory.


So two issues:

 - this symlink should not be there (already fixed), this was done when debugging the failures on the gtk perf-test runner (see bug 302152 and 302728@main )
 - the plugin should try a bit harder to check if that symlink ends resolving to a path inside the build-dir

[Carlos Alberto Lopez Perez]

Pull request: https://github.com/WebKit/WebKit/pull/54516

[EWS]

Committed 303603@main (c120510bb215): <https://commits.webkit.org/303603@main>

Reviewed commits have been landed. Closing PR #54516 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/165484382>