WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
303163
[JSC] Remove redundant `isValidISODate` check in `TemporalCalendar`
https://bugs.webkit.org/show_bug.cgi?id=303163
Summary
[JSC] Remove redundant `isValidISODate` check in `TemporalCalendar`
Sosuke Suzuki
Reported
2025-11-26 22:43:44 PST
The `isValidISODate` check after `regulateISODate` is redundant because: - When overflow is `Reject`, `regulateISODate` already calls `isValidISODate` and returns `std::nullopt` if invalid. - When overflow is `Constrain`, the month and day are clamped to valid ranges, so `isValidISODate` will always return true.
Attachments
Add attachment
proposed patch, testcase, etc.
Sosuke Suzuki
Comment 1
2025-11-26 22:44:48 PST
Pull request:
https://github.com/WebKit/WebKit/pull/54505
EWS
Comment 2
2025-12-03 18:15:30 PST
Committed
303878@main
(a1e2020dffa2): <
https://commits.webkit.org/303878@main
> Reviewed commits have been landed. Closing PR #54505 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2025-12-03 18:16:12 PST
<
rdar://problem/165805788
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug