Bug 30316 - Build scripts: unchecked return value in call to system()
Summary: Build scripts: unchecked return value in call to system()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-12 16:12 PDT by Mark Seaborn
Modified: 2009-10-14 14:41 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (2.51 KB, patch)
2009-10-12 16:27 PDT, Mark Seaborn 		no flags Details | Formatted Diff | Diff
Die if gperf fails (1.23 KB, patch)
2009-10-12 17:16 PDT, Mark Seaborn 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Seaborn 2009-10-12 16:12:08 PDT 
gperf is invoked via system() in the Perl build script WebCore/css/makevalues.pl, but the return value is not checked.  This means that if gperf is not installed, makevalues.pl will not fail properly and will produce incomplete output.  This causes build errors later on, and installing gperf does not fix the build because the build system is not aware that makevalues.pl's dependencies have changed.

There is a similar unchecked system() call in WebCore/css/makegrammar.pl.
Comment 1 Mark Seaborn 2009-10-12 16:27:21 PDT 
Created attachment 41066 [details]
Patch v1
Comment 2 Mark Seaborn 2009-10-12 17:16:40 PDT 
Created attachment 41068 [details]
Die if gperf fails
Comment 3 WebKit Commit Bot 2009-10-14 14:41:08 PDT 
Comment on attachment 41068 [details]
Die if gperf fails

Clearing flags on attachment: 41068

Committed r49584: <http://trac.webkit.org/changeset/49584>
Comment 4 WebKit Commit Bot 2009-10-14 14:41:11 PDT 
All reviewed patches have been landed.  Closing bug.