[...] CXX WebCore/platform/graphics/gtk/libWebCore_la-DataSourceGStreamer.lo WebCore/platform/graphics/gtk/DataSourceGStreamer.cpp: In function ‘gboolean webkit_data_src_uri_set_uri(GstURIHandler*, const gchar*)’: WebCore/platform/graphics/gtk/DataSourceGStreamer.cpp:217: warning: missing sentinel in function call Problem is, that 0 is an integer and integers are passed as 32 bit values on x86-64 while the function expects a 64 bit 0 as sentinel. This will cause crashes and havoc. Attached trivial patch fixes this.
Created attachment 41046 [details] 0001-Fix-0-sentinel-for-g_object_set-function-call.patch
Comment on attachment 41046 [details] 0001-Fix-0-sentinel-for-g_object_set-function-call.patch I'm not sure about the reasoning. I'm pretty sure gcc will complain about this, but I don't think we ever had a crash related to this. The patch is good, though.
Comment on attachment 41046 [details] 0001-Fix-0-sentinel-for-g_object_set-function-call.patch Clearing flags on attachment: 41046 Committed r49445: <http://trac.webkit.org/changeset/49445>
All reviewed patches have been landed. Closing bug.