Bug 30305 - [Qt] DumpRenderTree has missing features and needs refactoring
Summary: [Qt] DumpRenderTree has missing features and needs refactoring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-12 07:36 PDT by Andras Becsi
Modified: 2009-10-13 15:51 PDT (History)
2 users (show)

See Also:


Attachments
Refactoring LayoutTestController and related classes out of jsobjects, no functionality changes made yet. (110 bytes, text/plain)
2009-10-12 07:36 PDT, Andras Becsi
no flags Details
Removed qtcreator's template user.pro file from the proposed patch (75.34 KB, patch)
2009-10-12 07:44 PDT, Andras Becsi
no flags Details | Formatted Diff | Diff
corrected coding style issues (75.33 KB, patch)
2009-10-13 07:44 PDT, Andras Becsi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2009-10-12 07:36:57 PDT
Created attachment 41042 [details]
Refactoring LayoutTestController and related classes out of jsobjects, no functionality changes made yet.

DumpRenderTree and its parts in QtWebKit are in a very bad shape. To implement missing features and fix annoying phonon related crashes and timeouts on the buildbot it needs some refactoring.
Comment 1 Andras Becsi 2009-10-12 07:44:14 PDT
Created attachment 41043 [details]
Removed qtcreator's template user.pro file from the proposed patch
Comment 2 Andras Becsi 2009-10-13 07:44:19 PDT
Created attachment 41102 [details]
corrected coding style issues
Comment 3 WebKit Commit Bot 2009-10-13 15:51:21 PDT
Comment on attachment 41102 [details]
corrected coding style issues

Clearing flags on attachment: 41102

Committed r49519: <http://trac.webkit.org/changeset/49519>
Comment 4 WebKit Commit Bot 2009-10-13 15:51:24 PDT
All reviewed patches have been landed.  Closing bug.