Bug 303008 – [blocks-in-inline] Add spanning inline boxes on block lines

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[alan]

ssia

[alan]

Created attachment 477477 [details]
Patch

[Antti Koivisto]

Comment on attachment 477477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=477477&action=review

> Source/WebCore/layout/formattingContexts/inline/LineLayoutResult.h:105
> -        if (!runs.isEmpty() && runs[0].isBlock())
> -            return InflowContentType::Block;
> +        for (auto& run : runs) {
> +            if (run.isBlock())
> +                return InflowContentType::Block;
> +            ASSERT(run.isInlineBox());
> +        }

couldn't this be runs.last().isBlock()?

[alan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 477477 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=477477&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/LineLayoutResult.h:105
> > -        if (!runs.isEmpty() && runs[0].isBlock())
> > -            return InflowContentType::Block;
> > +        for (auto& run : runs) {
> > +            if (run.isBlock())
> > +                return InflowContentType::Block;
> > +            ASSERT(run.isInlineBox());
> > +        }
> 
> couldn't this be runs.last().isBlock()?
You are absolutely right. Let me fix that.

[alan]

Created attachment 477478 [details]
Patch

[alan]

Created attachment 477479 [details]
Patch

[alan]

Created attachment 477480 [details]
Patch

[alan]

Created attachment 477482 [details]
[fast-cq]Patch

[EWS]

Committed 303460@main (2b73cf2c0e08): <https://commits.webkit.org/303460@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 477482 [details].

[Radar WebKit Bug Importer]

<rdar://problem/165300314>