Bug 30300 - Web Inspector: Enforce async interaction between inspector controller and frontend
Summary: Web Inspector: Enforce async interaction between inspector controller and fro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-12 02:45 PDT by Pavel Feldman
Modified: 2009-10-13 01:17 PDT (History)
1 user (show)

See Also:

Attachments
patch (1.40 KB, patch)
2009-10-12 02:47 PDT, Pavel Feldman 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-10-12 02:45:10 PDT 
I think we should eliminate the possibility of reentering inspector controller code via frontend (this is actually important for layout tests harness to have no reenterability). It can be implemented in two ways: 
1) wrap all calls to InspectorController within frontend with setTimeouted(0) or
2) wrap frontend's dispatch

I think (2) is more appropriate at this moment.
Comment 1 Pavel Feldman 2009-10-12 02:47:00 PDT 
Created attachment 41027 [details]
patch
Comment 2 Timothy Hatcher 2009-10-12 10:15:18 PDT 
Comment on attachment 41027 [details]
patch

> +    function delayDispatch() {

Brace should be on new line.


> +    }
> +    setTimeout(delayDispatch, 0);

Put a new line after the brace.
Comment 3 Pavel Feldman 2009-10-13 01:17:24 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/inspector.js
Committed r49493