Bug 30298 - Web Inspector: Use proper web view in inspector layout tests for windows.
Summary: Web Inspector: Use proper web view in inspector layout tests for windows.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2009-10-12 02:01 PDT by Pavel Feldman
Modified: 2009-10-13 01:28 PDT (History)
2 users (show)

See Also:

patch (2.86 KB, patch)
2009-10-12 02:10 PDT, Pavel Feldman
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-10-12 02:01:53 PDT
Currently stub instance is being created instead of querying one from the frame. (I was going to submit it with the 'enable tests' change, but there is a blocking network-related issue there so I think it is worth submitting this independently).
Comment 1 Pavel Feldman 2009-10-12 02:10:21 PDT
Created attachment 41026 [details]
Comment 2 Pavel Feldman 2009-10-12 13:39:26 PDT
There are no changes to semantics there. I just did not wire it to the proper webview instance in the first place, was creating a dummy object instead. Now all pieces are in place and we are ready to enable tests. Tests now work in DRT mode on windows, so we are all set. (The application/octet-stream road block has been resolved by itself).
Comment 3 Adam Roben (:aroben) 2009-10-12 20:02:22 PDT
Comment on attachment 41026 [details]

Comment 4 Pavel Feldman 2009-10-13 01:28:58 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp
Committed r49496