Bug 30296 - [Qt] Add some initial autotests for QWebPage's ErrorPageExtention
Summary: [Qt] Add some initial autotests for QWebPage's ErrorPageExtention
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-10-11 21:22 PDT by Antonio Gomes
Modified: 2009-10-15 10:18 PDT (History)
1 user (show)

See Also:


Attachments
landed in r49498 - patch 0.1 - error page extension (3.48 KB, patch)
2009-10-11 21:30 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2009-10-11 21:22:59 PDT
i just came up w/ some basic auto tests for errorpage extension. At this iteraction the autotest just sets an error page, checks if it is what is shown afterwards and if back/forward history is in the right state after the error handling.

ps: i have noticed some problems w/ back/forward history that i will cover in another bug.
Comment 1 Antonio Gomes 2009-10-11 21:30:29 PDT
Created attachment 41018 [details]
landed in r49498 - patch 0.1 - error page extension
Comment 2 Simon Hausmann 2009-10-12 22:29:43 PDT
Comment on attachment 41018 [details]
landed in r49498 - patch 0.1 - error page extension

r=me

> +    ErrorPage(QWidget *parent = 0): QWebPage(parent)

Please fix the * position before landing.

Thanks for adding this test!
Comment 3 Antonio Gomes 2009-10-13 04:36:24 PDT
(In reply to comment #2)
> (From update of attachment 41018 [details])
> r=me
> 
> > +    ErrorPage(QWidget *parent = 0): QWebPage(parent)
> 
> Please fix the * position before landing.
> 
> Thanks for adding this test!

thx simon, 

landed in r49498
Comment 4 Antonio Gomes 2009-10-15 10:18:51 PDT
Comment on attachment 41018 [details]
landed in r49498 - patch 0.1 - error page extension

clearing r+ flag since patch has landed