Bug 30294 - [V8] Revision 49420 breaks V8 bindings adding CanvasActiveInfo
Summary: [V8] Revision 49420 breaks V8 bindings adding CanvasActiveInfo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-11 19:57 PDT by Dominic Cooney
Modified: 2009-10-11 20:30 PDT (History)
2 users (show)

See Also:

Attachments
Proposed fix. Includes CanvasActiveInfo in V8 binding generation. (4.69 KB, patch)
2009-10-11 20:09 PDT, Dominic Cooney 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2009-10-11 19:57:54 PDT 
Revision 49420 <http://build.chromium.org/buildbot/waterfall.fyi/changes/3610> adds an IDL-defined CanvasActiveInfo type and a couple of methods to CanvasGraphicsContext3D which return them. These methods break the V8 bindings because there's no V8 CanvasActiveInfo binding.
Comment 1 Dominic Cooney 2009-10-11 20:09:12 PDT 
Created attachment 41011 [details]
Proposed fix. Includes CanvasActiveInfo in V8 binding generation.
Comment 2 Adam Barth 2009-10-11 20:13:03 PDT 
Comment on attachment 41011 [details]
Proposed fix. Includes CanvasActiveInfo in V8 binding generation.

Thanks for the build fix!
Comment 3 WebKit Commit Bot 2009-10-11 20:30:46 PDT 
Comment on attachment 41011 [details]
Proposed fix. Includes CanvasActiveInfo in V8 binding generation.

Clearing flags on attachment: 41011

Committed r49432: <http://trac.webkit.org/changeset/49432>
Comment 4 WebKit Commit Bot 2009-10-11 20:30:51 PDT 
All reviewed patches have been landed.  Closing bug.