Bug 302896 – [WPE][GTK] WebKitFaviconDatabase.cpp:202:47: error: 'this' argument to member function 'leakRef' has type 'WTF::RefPtr<_cairo_surface> const', but function is not marked const

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Our changes to WebKitFaviconDatabase have broken the build on s390x. Once I have successfully ensured the build succeeds, I will use this bug to submit a fix.

/builddir/build/BUILD/webkitgtk-2.51.2-build/webkitgtk-2.51.2/Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp:202:47: error: 'this' argument to member function 'leakRef' has type 'WTF::RefPtr<_cairo_surface> const', but function is not marked const
  202 |             g_task_return_pointer(task.get(), icon.leakRef(), reinterpret_cast<GDestroyNotify>(cairo_surface_destroy));
      |                                               ^~~~
/builddir/build/BUILD/webkitgtk-2.51.2-build/webkitgtk-2.51.2/webkitgtk-6.0/redhat-linux-build/WTF/Headers/wtf/RefPtr.h:69:8: note: 'leakRef' declared here
   69 |     T* leakRef() WARN_UNUSED_RETURN;
      |        ^
1 error generated.

[Michael Catanzaro]

Pull request: https://github.com/WebKit/WebKit/pull/54344

[EWS]

Committed 303498@main (36f65d4be38b): <https://commits.webkit.org/303498@main>

Reviewed commits have been landed. Closing PR #54344 and removing active labels.